Mir Algorithm v0.5.8: Interpolation, Timeseries and 17 new functions
9il via Digitalmars-d-announce
digitalmars-d-announce at puremagic.com
Tue May 9 10:35:18 PDT 2017
On Monday, 8 May 2017 at 14:26:35 UTC, jmh530 wrote:
> On Monday, 8 May 2017 at 08:51:32 UTC, 9il wrote:
>> ## New modules
>> ...
>
> Great work.
>
> Some comments:
>
> mir.timeseries is a welcome addition. Calling (time, data)
> pairs moments will confuse because moment has another meaning
> in statistics. Perhaps observation?
Thanks. Fixed.
> Also, Series might also include data labels for columns. And
> access by data label.
I do not see good @nogc solution for now. PRs are welcome!
> The second part of the example for
> mir.ndslice.topology: slide
> is not that intuitive. It seems like what you're basically
> doing is the same as
> assert(sw == [8, 12, 16, 20, 24, 28, 32, 36]);
> (or something) but it's just less obvious to do it by a formula.
Fixed
> I don't know how strongly I feel about this, but I find the
> naming between minIndex/maxIndex and minPos/maxPos and
> minmaxIndex/minmaxPos strange. All three produce indices, it's
> just that the Pos do it backwards and minmax give both min and
> max. It seems like a lot of separate functions for things that
> could be done with one multi-purpose template. Regardless, if
> you keep it the way it is, then maybe given the plethora of
> finding functions, split it off to a separate module?
OK, I changed return type for *Pos functions.
No they return positions :-)
Thank you for the comments!
Best,
Ilya
More information about the Digitalmars-d-announce
mailing list