Wed Oct 17 - Avoiding Code Smells by Walter Bright

[rikki cattermole]

On 01/11/2018 2:25 AM, 12345swordy wrote:
> On Wednesday, 31 October 2018 at 13:22:28 UTC, rikki cattermole wrote:
>> On 01/11/2018 2:16 AM, 12345swordy wrote:
>>> On Wednesday, 31 October 2018 at 05:42:26 UTC, Nicholas Wilson wrote:
>>>> Running into such problems is a sign that your module is too large, 
>>>> and should become a package.
>>> I seen modules with more then thousand lines of code in the Phobos 
>>> library. What exactly consist a module of being "too large"? If 
>>> having two classes in a module with around 200-300 lines of code "too 
>>> large"?
>>
>> We have been splitting Phobos modules up:
>>
>> std.algorithm and most recently std.datetime
>>
>> They were MASSIVE as in 30k+ LOC massive.
> 
> That's nice.
> Again what consist of a module of being "too large"?
> That seems to me that more of a art then a science.

Because it is.

My rules (which tend to be a little stricter than most peoples) are:

Soft split 1k LOC, hard split 3k LOC without a very good reason not to.

But at the end of the day, it just depends on the scope of the module. 
Is it getting to large? If so, split.