[Issue 3463] Integrate Precise Heap Scanning Into the GC

[d-bugmail at puremagic.com]

http://d.puremagic.com/issues/show_bug.cgi?id=3463


Leandro Lucarella <llucax at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |llucax at gmail.com


--- Comment #3 from Leandro Lucarella <llucax at gmail.com> 2009-11-01 11:38:16 PST ---
The patch looks nice. I have some questions:

* Why did you choose to store the bitmask after the SENTINEL_POST and not
before? I think that storing the bitmask before the SENTINEL could let you
detect a corrupted bitmaks when version SENTINEL is compiled.

* In the bitMaskMixin string mixin you have a nested function setBitMask()
that's used only once. I wonder if you reused that function before or if you
put that code in a nested function just because you you think it's more clear
that way. It kind of confused me at first.

* Why is the bitMaskMixin a mixin and not just a plain function? I can't see
any reason to make it a string mixin, I am missing something? I find this very
confusing and makes the code harder to follow, since some variables appear from
nowhere.

Thanks for the good work.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------