[Issue 2276] Error message missing line number on array operation

[d-bugmail at puremagic.com]

http://d.puremagic.com/issues/show_bug.cgi?id=2276


Don <clugdbug at yahoo.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch


--- Comment #2 from Don <clugdbug at yahoo.com.au> 2010-05-18 00:12:06 PDT ---
Arrays ops still need more work, but this patch at least gives reasonable error
messages for everything it cannot handle, rather than generating errors on
compiler-generated code. This also fixes bug 3548, which is largely the same as
this one. 

PATCH:
arrayop.c.
----------------
Expression *BinExp::arrayOp(Scope *sc)
{
    //printf("BinExp::arrayOp() %s\n", toChars());

    if (type->toBasetype()->nextOf()->toBasetype()->ty == Tvoid)
    {
        error("Cannot perform array operations on void[] arrays");
        return new ErrorExp();
    }
+    if (!isArrayOpValid(e2))
+    {
+        e2->error("invalid array operation %s (did you forget a [] ?)",
toChars());
+        return new ErrorExp();
+    }
----------------
and add the following function to the top of that file.
----------------
// Check that there are no uses of arrays without [].
bool isArrayOpValid(Expression *e)
{
    if (e->op == TOKslice)
        return true;
    Type *tb = e->type->toBasetype();

    if ( (tb->ty == Tarray) || (tb->ty == Tsarray) )
    {
        switch (e->op)
        {
            case TOKadd:
            case TOKmin:
            case TOKmul:
            case TOKdiv:
            case TOKmod:
            case TOKxor:
            case TOKand:
            case TOKor:
            case TOKpow:
                 return isArrayOpValid(((BinExp *)e)->e1) &&
isArrayOpValid(((BinExp *)e)->e2);
            case TOKcall:
                 return false; // TODO: Decide if [] is required after arrayop
calls.
            case TOKneg:
            case TOKtilde:
                 return isArrayOpValid(((UnaExp *)e)->e1);
            default:
                return false;
        }
    }
    return true;
}

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------