[Issue 5019] New: In std.regex, empty capture at end of string causes error

[d-bugmail at puremagic.com]

http://d.puremagic.com/issues/show_bug.cgi?id=5019

           Summary: In std.regex, empty capture at end of string causes
                    error
           Product: D
           Version: D2
          Platform: x86_64
        OS/Version: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Phobos
        AssignedTo: nobody at puremagic.com
        ReportedBy: petevik38 at yahoo.com.au


--- Comment #0 from PeteC <petevik38 at yahoo.com.au> 2010-10-08 11:52:59 PDT ---
An empty capture before the end of the string seems to work fine:

    auto m = match( "abc", "ab(.*)c" );
    writefln( "'%s'", m.captures[1] );

-> ''


An empty capture at the end of a string results in the following assert error:

    auto m = match( "abc", "abc(.*)" );
    writefln( "'%s'", m.captures[1] );

->
core.exception.AssertError at c:\dmd2\windows\bin\..\..\src\phobos\std\regex.d(1705):
1

In Captures.length :

        @property size_t length()
        {
            foreach (i; 0 .. matches.length)
            {
                if (matches[i].startIdx >= input.length) return i;
            }
            return matches.length;
        }

The test will fail for an empty capture at the end because startIdx == endIdx
== input.length. This seems like it should be a valid case and the following
change seems to resolve the issue:

                if (matches[i].startIdx > input.length) return i;

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------