[Issue 7487] New: A faster std.bitmanip.BitArray.opCat

d-bugmail at puremagic.com d-bugmail at puremagic.com
Sun Feb 12 11:42:54 PST 2012


http://d.puremagic.com/issues/show_bug.cgi?id=7487

           Summary: A faster std.bitmanip.BitArray.opCat
           Product: D
           Version: D2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Phobos
        AssignedTo: nobody at puremagic.com
        ReportedBy: bearophile_hugs at eml.cc


--- Comment #0 from bearophile_hugs at eml.cc 2012-02-12 11:42:53 PST ---
This implements an operator on std.bitmanip.BitArray, to append one or more
bits at the beginning:


BitArray opCatAssign(BitArray b)
{
    auto istart = len;
    length = len + b.length;
    for (auto i = istart; i < len; i++)
        this[i] = b[i - istart];
    return this;
}


BitArray opCat_r(bool b)
{
    BitArray r;

    r.length = len + 1;
    r[0] = b;
    for (size_t i = 0; i < len; i++)
        r[1 + i] = this[i];
    return r;
}


I think there are faster ways to perform those operations, that avoid copying
single bits, and work mostly with a memmove() on the array of size_t pointed by
BitArray.ptr (followed by few single bit copies if necessary).

In my code I have found that opCat_r() to be slow.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------


More information about the Digitalmars-d-bugs mailing list