[Issue 11831] std.zip no longer allows setting madeVersion field in zip file

[d-bugmail at puremagic.com]

https://d.puremagic.com/issues/show_bug.cgi?id=11831


Martin Nowak <code at dawg.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull
                 CC|                            |code at dawg.eu


--- Comment #2 from Martin Nowak <code at dawg.eu> 2013-12-27 17:56:15 PST ---
https://github.com/D-Programming-Language/phobos/pull/1817

(In reply to comment #0)
> std.zip needs to allow access to all fields in zip file's data structures. The
> data structures written to disk should not have inaccessible private fields.

The fact that std.zip is barely unusable and that most of it's members are
undocumented should tell you a different story.
madeVersion was explicitly documented as read only field btw.
http://dlang.org/phobos/std_zip.html#.ArchiveMember.madeVersion

> This regression blocks compilation of the chmodzip tool, which needs to be able
> to set madeVersion because Linux unzippers look for specific version numbers
> there.

The set version number (20) works fine, it's 0x0300 in the upper byte which
needs to be set for Unix format file attribute.
https://github.com/D-Programming-Language/phobos/blob/e37d30fb10b94f8a3ac9013d92c7be661e52eb6b/std/zip.d#L136

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------