[Issue 12075] Required disk space of Windows installer is 0kB

[d-bugmail at puremagic.com]

https://d.puremagic.com/issues/show_bug.cgi?id=12075



--- Comment #4 from Brad Anderson <eco at gnuk.net> 2014-02-04 14:51:28 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > It would be generally preferable to only embed those files that are actually
> > needed for a Windows installation, not the whole dmd.zip.
> 
> Is it difficult to embed zip files?
> Ideally we could simply use the dmd.windows.zip generated by
> create_dmd_release.
> http://ftp.digitalmars.com/dmd.2.065.0-b3.windows.zip 15.2MB

Nope, it already supports doing that actually. You just comment out the
"!define Download" near the top and have zip files in place for it to snag.
https://github.com/D-Programming-Language/installer/blob/master/windows/dinstaller.nsi#L146

What I meant though is using NSIS's "File" to include the files rather than
including a zip file with everything already included.  If there is a directory
dmd.windows.zip is made from we'd ideally just "File /r <path>" that directory
and then we'd have a non-downloading installer that only includes the relevant
portions, has a true Space Required amount, and would actually be smaller
because NSIS can do LZMA compression.

This would also fix the problem of ensuring the uninstall only removes files it
installed itself (there are readymade solutions for this as long as you are
using NSIS's built in file embedding).

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------