[Issue 15910] Prevent mismatch of VERSION information in dmd releases

[via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=15910

--- Comment #2 from Joseph Rushton Wakeling <joseph.wakeling at webdrake.net> ---
> That's not entirely correct b/c the downloadable packages contain the correct VERSION file

Well, yes, that's really the point of concern -- there is a mismatch between
the downloadable packages (correct version) and the git-hosted source
(incorrect version), that shouldn't be there.

> Now we could validate that the VERSION file contains the to be build tag, but this will be a constant nuisance, e.g. deleting already created tags, changing the VERSION from 2.071.0-b1 to 2.071.0-b2, retag, and build.

I'm not sure I follow the concern here.  If there are multiple version tags on
a single commit, isn't the norm to just take the highest version out of all of
them?  And then compare to VERSION contents ... ?

> I'd instead suggest that any build script using the git repo or tags, should get the VERSION from git or write the VERSION file when downloading a tar bundle from github.

Yes, it makes sense that git tags might be the principal source of version
information and that VERSION should derive from that.  Probably this could
address both the issue described here and
<https://issues.dlang.org/show_bug.cgi?id=12229> all in one go?

> VERSION can also be set through make -f posix.mak VERSION=2.071.0

Thanks, that's useful.

--