[Issue 16699] [REG 2.070] stack corruption with scope(exit)

via Digitalmars-d-bugs digitalmars-d-bugs at puremagic.com
Tue Nov 22 13:58:10 PST 2016


https://issues.dlang.org/show_bug.cgi?id=16699

--- Comment #16 from Steven Schveighoffer <schveiguy at yahoo.com> ---
(In reply to Ketmar Dark from comment #15)
> the whole process is broken: under no circumstances any hotfix that is
> applicable both to master and to stable can land in stable first.

It's advantageous to do it "all at once" instead of one at a time.

Keep in mind that the auto tester needs to test all these. I'd rather have it
test the "whole thing" at once one time rather than test each hotfix as it's
produced when it's already been tested on stable.

In addition, the PRs for merging stable to master are not always
straightforward. Less work if you do it all at once.

(In reply to hsteoh from comment #10)
> Is it customary to close bugs once they are fixed in stable, even though the
> fix has not yet been merged to git HEAD?

Yes, once a commit happens, the issue should be closed, as long as it's going
to go into master. Imagine if someone notices this is not fixed, and creates a
PR for master without realizing it's already fixed :) Not that I've ever done
that...

Note that anyone can create a PR to merge stable to master. It's just another
PR.

--


More information about the Digitalmars-d-bugs mailing list