[Issue 15857] incorrect checkimports mismatch for overload sets

via Digitalmars-d-bugs digitalmars-d-bugs at puremagic.com
Fri Sep 16 15:04:16 PDT 2016


https://issues.dlang.org/show_bug.cgi?id=15857

--- Comment #14 from github-bugzilla at puremagic.com ---
Commits pushed to stable at https://github.com/dlang/dmd

https://github.com/dlang/dmd/commit/c5822394c89c98a8855302164433acf6db09208b
fix Issue 15857 - incorrect checkimports mismatch for overloadsets

- properly fix Issue 15857 by comparing overload sets for equality
  (see 082e1199c258e99f7867ca33509db9ae9a31f3ae or #5681 for the previous fix)
- caching them in the local symbol table doesn't fully fix the issue b/c the
  table is not checked w/ SearchImportsOnly (see added test case)
- also with -transition=checkimports adding an overload set to the local
  symbol table will return that overload set for locals only searches,
  even though it might contain imported overloads (see readded dip22e
deprecation)
- might still make sense to correctly cache overload sets at some point,
  but they shouldn't be that common

https://github.com/dlang/dmd/commit/9ef10b73175ffb5ba6c638eef77bcdb243115026
Merge pull request #6136 from MartinNowak/fix15857

fix Issue 15857 - incorrect checkimports mismatch for overloadsets

--


More information about the Digitalmars-d-bugs mailing list