[Issue 20780] Function parameter UDA not accepted in nested function declarations
d-bugmail at puremagic.com
d-bugmail at puremagic.com
Fri May 1 12:17:43 UTC 2020
https://issues.dlang.org/show_bug.cgi?id=20780
Basile-z <b2.temp at gmx.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ben.james.jones at gmail.com
--- Comment #5 from Basile-z <b2.temp at gmx.com> ---
@benjones, thanks for taking the time to handle the PR. Since I cannot register
on GH anymore here's a small review.
1. Check the formating of the case statement. The oginal patch was formatted
correctly apparently
(https://issues.dlang.org/attachment.cgi?id=1780&action=diff VS
https://github.com/dlang/dmd/pull/11086/files#diff-cd066d37445cac534313c0137c2d4bbeR7274)
2. in order not to loose the authorship info, that are available with the
patch, you must use:
$ git checkout -b issue-20780
$ git am 0001-fix-issue-20780-Function-parameter-UDA-not-accepted-.patch
instead of:
$ git checkout -b issue-20780
$ git apply 0001-fix-issue-20780-Function-parameter-UDA-not-accepted-.patch
--
More information about the Digitalmars-d-bugs
mailing list