Code review: JSON unmarshaller

[Jacob Carlborg]

On 2012-10-15 21:03, Tyler Jameson Little wrote:
> https://gist.github.com/3894337
>
> This is my first non-trivial D code, and I'd eventually like to get this
> into Phobos as part of std.json.
>
> I haven't written the marshaller yet, but that shouldn't be too hard. I
> wanted to get some feedback on whether this code is up to the quality
> standards of Phobos.

I'm not sure what your goal with this marshaller is but I would say it's 
a lot harder than you think if you want to have a complete serialization 
library. A couple of things making it harder to create a fully working 
serialization library:

* Pointers
* Array slices
* Serializing through base class references
* const/immutable fields
* Any reference type (not really hard but it's more work)

Have a look at for a basically fully working serialization library Orange:

https://github.com/jacob-carlborg/orange

-- 
/Jacob Carlborg