core/sys/windows/windows.d is executable

Benjamin Thaut code at benjamin-thaut.de
Sat Sep 28 02:19:20 PDT 2013


Am 28.09.2013 11:16, schrieb Joseph Rushton Wakeling:
> On 27/09/13 21:13, Jonathan M Davis wrote:
>> No, it should not be executable. The only time that it makes sense for
>> a .d
>> file to be executable is when it's a script with something like
>> #!/bin/rdmd at
>> the top, which certainly isn't the case for windows.d.
>
> Is testing for correct permissions something that can be included in the
> auto-tester?  Seems likely that it could happen again by accident if
> someone edits windows.d on Windows (which is probably the most typical
> place to edit it).

Wouldn't it make more sense to automatically remove execute permission 
instead of testing against them? For someone only developing on windows 
it will not help when the autotester rejects the pull request just 
because it hase been made from a windows machine.


More information about the Digitalmars-d-learn mailing list