Minimum PR size

Jacob Carlborg via Digitalmars-d-learn digitalmars-d-learn at puremagic.com
Tue Jan 31 23:40:26 PST 2017


On 2017-01-31 11:36, Jason Schroeder wrote:
> I am interested in contributing to D on GitHub, and was wondering if
> there is a minimum or preferabe minimum size of a pull request; e.g. I
> woukd like to work on increasing code coverage, and am wondering if a
> pull request with one additional line of code, e.g. one assert () in a
> unittest block, would be considered not worth the time to consider as a PR?

The smaller PR the better :). There's more of an issue if the PR is too 
big. But adding one assert to one unit test block in ten different PR's 
might not be appropriate.

-- 
/Jacob Carlborg


More information about the Digitalmars-d-learn mailing list