Variables too big (std.date (...) int day???)

orgoton orgoton at mindless.com
Wed Feb 7 12:47:17 PST 2007


On my programming style, I always use the smallest variable possible.

Currently I'm updating the DDoc documentation on Phobos (using the sources found on /src/phobos).

First and foremost, these are the sources that I should be altering right? Later on I'm going to upload them to BugZilla on issue 667 (http://d.puremagic.com/issues/show_bug.cgi?id=677), is this the right place?

Second, I noticed that in some places, too big variable types are used, like "int day" when the number is never expected to be smaller than 31. Why not use something like "ubyte day"? Should I change this or should I limit myself on Documentation Comments?

Third, the changes I made get reviewed by someone before inclusion on Phobos,so that any typos and such get correct. Am I correct?

Thanks very much for any answers.



More information about the Digitalmars-d mailing list