CURL review request

[jdrewsen]

Den 16-08-2011 16:43, Alix Pexton skrev:
> On 16/08/2011 12:48, Jonas Drewsen wrote:
>> Hi all,
>>
>> This is a review request for the curl wrapper. Please read the "known
>> issues" in the top of the source file and if possible suggest a solution.
>>
>> We also need somebody for running the review process. Anyone?
>>
>> Code:
>> https://github.com/jcd/phobos/blob/curl-wrapper/etc/curl.d
>> Docs:
>> http://freeze.steamwinter.com/D/web/phobos/etc_curl.html
>>
>> Demolish!
>>
>> /Jonas
>
> Spotted another issue...
>
> In the example for Protocol.onReceive, there is a mismatch between the
> parameter names specified for the delegate and those used inside it.

you mean this one:

client.onReceive = (ubyte[] data) { writeln("Got data", cast(char[]) 
data); return data.length;};

I cannot identify the problem?

> Also, all the XREF macros point to std_curl.html. instead of
> etc_curl.html, is this going to become std.curl when incorporated into
> Phobos?
>
> A...

A fix to the std ddoc config is needed.

As explained in reply to another post I believe this wrapper should be 
put in the etc package.

/Jonas