etc.curl: Formal review begin
Johannes Pfau
spam at example.com
Wed Aug 24 07:34:26 PDT 2011
Damn, I forgot the most important part:
etc.curl currently uses none of D's "advanced" function attributes.
This means that etc.curl can't be used in safeD for example. IMHO
that's a big problem: New phobos code should be usable in safeD it's
bad enough that lots of old code isn't.
So:
@safe or @trusted needs to be added to almost all functions in etc.curl.
'const' (as in const functions, not const arguments) probably doesn't
make sense for a wrapper, so that's not needed.
There are some functions which could be 'pure': escape & unescape for
example
Seems like most functions can throw, but maybe some are 'nothrow'.
--
Johannes Pfau
More information about the Digitalmars-d
mailing list