Formal Review of std.regex (FReD)

[Dmitry Olshansky]

On 08.10.2011 23:56, Jesse Phillips wrote:
> Hello everyone,
>
> I have taken the role of review manager of the std.regex replacement by
> Dmitry Olshansky. The review period begins now 2011-10-8 and will end on
> 2011-10-23 at midnight UTC. A voting thread to include into Phobos will
> be held after review assuming such is appropriate. The Voting period is
> one week.
>
> Please note that you can try FRed as part of Phobos (Code) or by itself
> (Package of FReD) which includes docs.
>
> Doc:
>
> http://nascent.freeshell.org/fred/doc/
>
> Code:
>
> https://github.com/blackwhale/phobos MASTER
>
> Package of FReD:
>
> https://github.com/downloads/blackwhale/FReD/FReD.zip
>
> Remember this will be replacing the current std.regex and is intended to
> be a drop in replacement. This project is also part of GSoC.
>
> Dmitry, I ask that you apply this patch to posix.mak (adding to internal
> modules).
>
> --- a/posix.mak
> +++ b/posix.mak
> @@ -184,7 +184,8 @@ std/c/, fenv locale math process stdarg stddef stdio
> stdlib
>   time wcharh)
>   EXTRA_MODULES += $(EXTRA_DOCUMENTABLES) $(addprefix                    \
>          std/internal/math/, biguintcore biguintnoasm biguintx86 \
> -       gammafunction errorfunction) std/internal/processinit
> +       gammafunction errorfunction) std/internal/processinit \
> +       std/internal/uni std/internal/uni_tab
>
>   # Aggregate all D modules relevant to this build
>   D_MODULES = crc32 $(STD_MODULES) $(EXTRA_MODULES) $(STD_NET_MODULES)

Thanks, updated and now it works on linux for me. Though it wasn't that 
simple.

I've found out what caused my builds to break. The thing is that both 
std.file & std.stdio use fully qualified std.c.stdio.func calls but 
never actually import std.c.stdio in any way. I wasn't even aware that's 
possible.

So I changed it to core.stdc in std.file and added static import to 
std.stdio (some functions from std.c are not present in core.stdc 
apparently).  If there is any problem with that I can revert it, and 
investigate why it affects only me ;)


-- 
Dmitry Olshansky