The review of std.hash package

Regan Heath regan at netmail.co.nz
Thu Aug 9 03:16:36 PDT 2012


On Thu, 09 Aug 2012 10:58:10 +0100, Johannes Pfau <nospam at example.com>  
wrote:

> Am Thu, 09 Aug 2012 11:32:34 +0200
> schrieb "Vladimir Panteleev" <vladimir at thecybershadow.net>:
>
>> On Tuesday, 7 August 2012 at 17:39:50 UTC, Dmitry Olshansky wrote:
>> > std.hash.hash is a new module for Phobos defining an uniform
>> > interface for hashes and checksums. It also provides some
>> > useful helper functions to deal with this new API.
>>
>> Is it too late to ask to include MurmurHash 2 and/or 3? It's
>> public domain, and great for things like hash tables.
>>
>> You can steal some code from here:
>> https://github.com/CyberShadow/ae/blob/master/utils/digest.d
>> https://github.com/CyberShadow/ae/blob/master/utils/digest_murmurhash3.d
>>
>
> To be honest I didn't even know that MurmurHash can be used
> incrementally. I could port that code soon, but I think it's
> best to do it after the review.
> After we have formalized a common API adding new hashes probably won't
> require a full review. It should be possible to do that as a pull
> request.

Once the API is formalised I can contribute the hashes I have also :)

R


-- 
Using Opera's revolutionary email client: http://www.opera.com/mail/


More information about the Digitalmars-d mailing list