Review of Jose Armando Garcia Sancio's std.log

[Jose Armando Garcia]

On Mon, Feb 13, 2012 at 7:50 AM, David Nadlinger <see at klickverbot.at> wrote:
> There are several modules in the review queue right now, and to get things
> going, I have volunteered to manage the review of Jose's std.log proposal.
> Barring any objections, the review period starts now and ends in three
> weeks, on March 6th, followed by a week of voting.
>

Hi everyone,

I have been tracking all the changes we need to make immediately and
things we can add in the future without break backward compatibility
if have access to trello go here:
https://trello.com/card/std-log/4f33d3c6542c156960533efb/1#

Exporting things form trello looks like a pain but here it is:

Future:

1. Allowing filtering of regular log messages (like info, warning,
etc) based on the module. Similar to how vlog works.
2. Add support for custom line formatters
3. Talk about adding config.setSeverity(...) which is a union of all
the severity specified. The logical OR operator is not going to work
because internally the values are 0,1, etc. and we use them to index
into an array. One solution is to pass an array to
config.setSeverity(...)

Fix now:

1. Add thread name attribute to the default logger
2. Check that the example compile
3. Come up with a better name for Rich and rich template
4. Add @safe pure nothrow const to as many methods as possible
5. Remove check when setting Configuration.logger

Note: There were a few other things that were suggested here that I
have already fixed. Need to look at my commits for this.

Thanks,
-Jose

> ---
> Code:
> https://github.com/jsancio/phobos/commit/d114420e0791c704f6899d81a0293cbd3cc8e6f5
> Docs: http://jsancio.github.com/phobos/phobos/std_log.html
>
> Known remaining issues:
>  - Proof-reading of the docs is required.
>  - Not yet fully tested on Windows.
>
> Depends on: https://github.com/D-Programming-Language/druntime/pull/141
> (will be part of 2.058)
> ---
>
> Earlier drafts of this library were discussed last year, just search the NG
> and ML archives for "std.log".
>
> I think getting this right is vitally important so that we can avoid an
> abundance of partly incompatible logging libraries like in Java. Thus, I'd
> warmly encourage everyone to actively try out the module or compare it with
> any logging solution you might already be using in your project.
>
> Please post all feedback in this thread, and remember: Although
> comprehensive reviews are obviously appreciated, short comments are very
> welcome as well!
>
> David