Request for Review: DI Generation Improvements

[Alex Rønne Petersen]

On 15-05-2012 02:20, Tyro[17] wrote:
> On Tuesday, 15 May 2012 at 00:02:23 UTC, Alex Rønne Petersen wrote:
>> On 15-05-2012 01:50, Adam Wilson wrote:
>>> I am formally requesting review of the two pull requests that make up my
>>> DI Generation Improvements patch.
>>>
>>> The first pull is against the DRuntime and modifies the makefiles such
>>> some files in the DRT are not generated as DI files but copied from
>>> the D
>>> source files directly into the DI file. This solves a problem where
>>> certain portions of Phobos the CTFE into the DRT cause a build failure
>>> when using the new DI generation. The files that are copied instead of
>>> generated are all of core and core.stdc, EXCEPT core.atomic, core.cpuid,
>>> core.demangle, and core.thread.
>>>
> [snip]
>>
>> I would suggest excluding core.[atomic,cpuid,demangle] from DI
>> generation, too, and just copy them. I don't see any reason to do DI
>> generation for them.
>
> Reread the last line of the paragraph starting with "The first pull".
> Your concern is already addressed.

No, you got it backwards. Before my comment, his pull request still 
caused DI generation to happen for the modules I mentioned, and I 
suggested simply copying them like the rest.

-- 
- Alex