[RFC] ColorD

Jens Mueller jens.k.mueller at gmx.de
Sun Oct 21 14:18:54 PDT 2012


Robik wrote:
> On Sunday, 21 October 2012 at 21:01:21 UTC, Jens Mueller wrote:
> >Interesting looks solid to me.
> >Some nit-picks:
> >* Coloring on Posix depends a ANSI terminal. Can you check that a
> >terminal is ANSI compatible?
> 
> Sure, why not.

Do you know how to do this?

> >* There are some magic numbers in the code. These may be difficult
> >to
> >  figure out for maintaining.
> 
> I will fix this.
> 
> >* enum Color should maybe be same on all systems.
> >  This is a rather small issue. But I may transfer the Color to
> >another
> >  system. So if it is possible there should only be one enum Color
> >for
> >  all systems.
> 
> I think that this will only complicate the code.

Probably not worth the trouble. But it should be documented.

> >* Call it terminal or similar. Because other terminal related
> >stuff can
> >  be added and IMHO it's a better name.
> 
> It got renamed to ConsoleD.

But the module should not be named colsoled. Because it's a D module
anyway. Call it just console.

> >I have written a similar library. Not finished. Let's join forces.
> >https://github.com/jkm/terminal
> >
> >Johannes Pfau has written a progress bar. I will add this.
> >
> >Jens
> 
> Sure, I'm interested in joining forces. Do you have IRC?

Yes, I do.

Jens


More information about the Digitalmars-d mailing list