Formal Review of std.process

[Johannes Pfau]

Am Sun, 07 Apr 2013 20:52:11 +0200
schrieb "Lars T. Kyllingstad" <public at kyllingen.net>:

> On Friday, 5 April 2013 at 05:54:39 UTC, Lars T. Kyllingstad 
> wrote:
> > The following is a message posted by Johannes Pfau to the other 
> > (pre-)review thread which didn't seem to get noticed, along 
> > with an edited version of my reply.
> >
> > On Sunday, 31 March 2013 at 13:14:52 UTC, Johannes Pfau wrote:
> >>
> >> Reposted from github:
> >> I think it would be nice if the high level functions would 
> >> also allow
> >> using custom environment variables. So the execute and 
> >> executeShell
> >> functions should have overloads which accept a string[string] 
> >> with
> >> environment variables (and probably accept a Config as well).
> >>
> >> The execute and executeShell functions would be trivial to 
> >> implement
> >> though if pipeProcess / pipeShell had an overload with 
> >> environment
> >> and Config parameters. So it's probably more important that
> >> pipeProcess / pipeShell get these overloads.
> 
> I have implemented this now.  I think this was a great 
> improvement.  pipeProcess(/-Shell) and execute(Shell) now wield 
> more of the power of spawnProcess(/-Shell) without complicating 
> their usage.
> 
> Please comment.
> 
> Lars

Thanks!
Looks good to me :-)