std.serialization: pre-voting review / discussion

Dicebot public at dicebot.lv
Mon Aug 12 06:27:43 PDT 2013


Stepping up to act as a Review Manager for Jacob Carlborg 
std.serialization

---- Input ----

Code: https://github.com/jacob-carlborg/phobos/tree/serialization

Documentation: 
https://dl.dropboxusercontent.com/u/18386187/docs/std.serialization/index.html

Previous review thread: 
http://forum.dlang.org/thread/adyanbsdsxsfdpvoozne@forum.dlang.org

---- Changes since last review ----

- Sources has been integrated into Phobos source tree
- DDOC documentation has been provided in a form it should look 
like on dlang.org
- Most utility functions/template code depends on have been 
inlined. Remaining `package` utility modules:
     * std.serialization.archives.xmldocument
     * std.serialization.attribute
     * std.serialization.registerwrapper

---- Information for reviewers ----

Goal of this thread is to detect if there are any outstanding 
issues that need to fixed before formal "yes"/"no" voting 
happens. If no critical objections will arise, voting will begin 
starting with a next week.

Please take this seriously: "If you identify problems along the 
way, please note if they are minor, serious, or showstoppers." 
(http://wiki.dlang.org/Review/Process). This information later 
will be used to determine if library is ready for voting.

If there are any frequent Phobos contributors / core developers 
please pay extra attention to submission code style and fitting 
into overall Phobos guidelines and structure.

-------------------------------------

Let the thread begin.

Jacob, it is probably worth creating a pull request with latest 
rebased version of your proposal to simplify getting a quick 
overview of changes. Also please tell if there is anything you 
want/need to implement before merging.


More information about the Digitalmars-d mailing list