std.serialization: pre-voting review / discussion

[Dmitry Olshansky]

13-Aug-2013 16:48, Dicebot пишет:
> On Monday, 12 August 2013 at 19:55:01 UTC, Jacob Carlborg wrote:
>> I don't think a pull request should be made before a module has gone
>> through the review queue and is approved. With Github it's easy to
>> diff between a fork and upstream:
>> https://github.com/jacob-carlborg/phobos/compare/serialization
>
> Agreed.
>
>> * I forgot to add that the unit tests are, a bit controversial,
>> located in std.serialization.tests
>
> That is something that requires the input from Phobos devs.

IMHO a good idea to have a non-trivial test suite to be separate so that 
it doesn't not clutter other module(s). That said isolated tests for 
individual pieces and internal stuff are better kept together with the 
code they test.

-- 
Dmitry Olshansky