D pullrequest review process rant

Walter Bright newshound2 at digitalmars.com
Thu May 9 11:22:32 PDT 2013


On 5/9/2013 11:15 AM, Brad Anderson wrote:
> On Thursday, 9 May 2013 at 18:10:47 UTC, Walter Bright wrote:
>> On 5/9/2013 1:48 AM, Russel Winder wrote:
>>> The positive lesson from Go is that application of one, and only one,
>>> formatting style, backed up by a tool incorporated into the compiler,
>>> does lead to the avoidance of bikeshedding and to community peace — just
>>> not world peace.
>>
>> I'd support the development of a dfmt, and using it to automatically reject
>> pull requests for phobos that don't pass it.
>
> I think even neater would be a tool that sends a pull request to the source
> repo/branch with the format changes so the author can just apply them with a click.

It could also start off as something as simple as:

1. no tabs
2. LF line endings (no CRLF)
3. no trailing whitespace


More information about the Digitalmars-d mailing list