std.d.lexer: pre-voting review / discussion

Brian Schott briancschott at gmail.com
Wed Sep 25 09:52:42 PDT 2013


On Wednesday, 25 September 2013 at 09:36:43 UTC, Jacob Carlborg
wrote:
> * I see that errorMessage throws an exception. Do we really 
> want that? I would except it just returns an invalid token.

This is the default behavior that happens when you don't
configure an error callback.

> * Could we get some unit tests for string literals, comments 
> and identifies out side of the ASCII table

I've added one.

> * Could you remove debug code and other code that is commented 
> out:

Most of this is now gone.

> Spell errors:

These were fixed weeks ago.


More information about the Digitalmars-d mailing list