Formal review of std.buffer.scopebuffer

Andrei Alexandrescu SeeWebsiteForEmail at erdani.org
Mon Mar 17 13:31:42 PDT 2014


On 3/17/14, 12:28 PM, Jacob Carlborg wrote:
> On 2014-03-17 20:07, Walter Bright wrote:
>
>> ScopeBuffer has been there and commented on for about 2 months now.
>
> That's because you created a pull request instead of asking for a formal
> review. A pull request should NOT be created until a module is accepted
> after a review and voting.
>
> You're sneaking in a new module although it has not gone through a
> formal review. This is not how new modules should be added.

I had the same concerns about it being front and center in std. Now that 
it's internal that issue disappears - we can use it inside Phobos for a 
while and change it without disrupting users. In many ways putting it up 
for review after all makes things better for everybody.

Andrei




More information about the Digitalmars-d mailing list