Formal review of std.buffer.scopebuffer

Jacob Carlborg doob at me.com
Tue Mar 18 00:40:22 PDT 2014


On Monday, 17 March 2014 at 20:20:46 UTC, Walter Bright wrote:

> Internal modules do not need the formal review process, since 
> they are not documented and not part of the public facing API, 
> any more than other changes to the internals of Phobos 
> functions need such review.

That's how it ended up being merged. That's not how it started. 
You created a pull request for a public visible new module 
without asking for a formal review. You have done this before. 
Please stop doing this.

> The review of ScopeBuffer on the github PR threads has been far 
> more thorough than about any other. It's up to 260 comments on 
> about 50 lines of actual code over about 2 months.

Doesn't matter. Just follow the protocols. What's the problem 
with that?

--
/Jacob Carlborg


More information about the Digitalmars-d mailing list