Formal review of std.buffer.scopebuffer

Andrei Alexandrescu SeeWebsiteForEmail at erdani.org
Tue Mar 18 08:59:22 PDT 2014


On 3/18/14, 12:45 AM, Jacob Carlborg wrote:
> On Monday, 17 March 2014 at 20:31:36 UTC, Andrei Alexandrescu wrote:
>
>> I had the same concerns about it being front and center in std. Now
>> that it's internal that issue disappears - we can use it inside Phobos
>> for a while and change it without disrupting users. In many ways
>> putting it up for review after all makes things better for everybody.
>
> I don't think that issue disappears. Walter has done this before and now
> he did it again. Creating a pull request for a new module without asking
> for a formal review. It's less of a problem that it was merged as an
> internal module. The big issue trying to get everyone to follow the
> protocols we have for adding new modules.

I don't think we need a formal review process for internal modules. 
Proper review of the pull request should suffice.

Andrei




More information about the Digitalmars-d mailing list