Reviewing pull requests

[Brad Roberts]

On 3/24/14, 2:26 PM, Steven Schveighoffer wrote:
> On Mon, 24 Mar 2014 16:53:36 -0400, Brad Roberts <braddr at puremagic.com> wrote:
>
>> On 3/24/14, 1:48 PM, Steven Schveighoffer wrote:
>>> On Mon, 24 Mar 2014 16:11:34 -0400, Andrej Mitrovic <andrej.mitrovich at gmail.com> wrote:
>>>
>>> 2 things:
>>>
>>> 1. Pulls that are waiting for author changes, but haven't been touched in a week (maybe?) should be
>>> closed. They can always be reopened.
>>> 2. Pulls that are closed do not get tested, so they are not using up cycles on the auto tester.
>>
>> Older than 2 weeks and they aren't likely to get tested either.. since any change to the branch
>> (ie, a pull being merged) restarts testing, so they're effectively just dead weight down the
>> queue.  Only a lull in pull merging would allow them to be tested, which is fine since a lull in
>> activity would otherwise just result in idle testers.  So, really #2 is a non-issue.
>
> OK, so it tests in reverse chronological? That makes the most sense. I was worried it was taking
> away time from other test runs.
>
> If a test has been started, and a merge occurs, does it stop the test?
>
> -Steve

The sync between github and the tester isn't instant, so time is sometimes wasted on an already 
merged pull.  However, it does check between steps to see if the run has been marked as old.  If so, 
it stops working on it.