Formal review of dtoh

Chris Williams yoreanon-chrisw at yahoo.co.jp
Thu Mar 27 18:03:37 PDT 2014


On Tuesday, 25 March 2014 at 20:38:40 UTC, Jacob Carlborg wrote:
> Code: https://github.com/adamdruppe/tools/blob/dtoh/dtoh.d

The author might consider using an associative array of functions 
to handle the various keywords, rather than switches.

I would suggest adding a "jsonutils.d" or somesuch, to break out 
the re-usable bits from the task-specific ones.

"scope (exit)" should be used to add the #endif to the end of the 
.h files. Also, there should be a comment with the guard name 
after it. (May as well try and create a nice-looking .h file).


More information about the Digitalmars-d mailing list