std.experimental.logger formal review round 3

Robert burner Schadek via Digitalmars-d digitalmars-d at puremagic.com
Sat Oct 11 06:34:27 PDT 2014


On Saturday, 11 October 2014 at 13:16:18 UTC, Martin Nowak wrote:
> On 09/28/2014 02:24 PM, Dicebot wrote:
>> Important changes since last review:
>> - new approach for compile-time log level filtering
>
> What's new here? It still relies on version identifiers to do 
> so.
> As I said in some earlier review, I think it's a bad idea for a 
> library to rely on version identifiers that are defined in 
> client code.
> I will only work for templated code and makes it much harder 
> for build tools. In a way it's the equivalent of
>     #define LOG_LEVEL 2
>     #include <logger.h>

All that code is contained in 30 line template, That is by far 
the best working option anybody could come up with

>
> I even proposed an alternative that uses type tags instead.
> http://dpaste.dzfl.pl/95fb6a4e086d

And I showed that it did not work.

> - Documentation is out of sync.
gh-page is yes, give me 15min

> - ArrayLogger seems to do about the same as MultiLogger
have you read my reply to Jacob
> - Why do loggers have to be classes?
As answered multiply times before, to build log hierarchies.




More information about the Digitalmars-d mailing list