Wanted: Review manager for std.data.json

[weaselcat via Digitalmars-d]

On Thursday, 9 April 2015 at 19:43:13 UTC, Sönke Ludwig wrote:
> Am 09.04.2015 um 21:40 schrieb Sönke Ludwig:
>> Am 09.04.2015 um 21:37 schrieb weaselcat:
>>> On Thursday, 9 April 2015 at 19:35:24 UTC, Sönke Ludwig wrote:
>>>> Am 09.04.2015 um 21:26 schrieb weaselcat:
>>>>> On Thursday, 9 April 2015 at 19:17:48 UTC, Sönke Ludwig 
>>>>> wrote:
>>>>>
>>>>>> Not sure, but that may also have been my recent 
>>>>>> optimizations.
>>>>>
>>>>> Just tried it with your recent optimizations and it doesn't 
>>>>> build with
>>>>> LDC 0.15.1.
>>>>
>>>> Should work now. I just tested LDC with -singleobj and it's 
>>>> faster
>>>> than RapidJSON! Now the DOM parser gets interesting.
>>>
>>> What flags are you using? RapidJSON is still a lot faster for 
>>> me.
>>> also, I just realized the build script has the wrong inline 
>>> flag for
>>> LDC(it's using -enable-inlining instead of -inline)
>>
>> I'll have to test with that exact version, because I've used 
>> my own
>> main() function for the test. The flags were: -singleobj 
>> -release -O5
>> -enable-inlining -disable-bondscheck (-disable-boundscheck is 
>> only a
>> little faster).
>
> One thing about the D benchmark is that it uses readText(). To 
> be a fair comparison with Rapid it would have to use 
> cast(string)read() instead.

I saw that commit to the benchmark and changed it locally.
They're about the same performance now comparing clang to LDC, 
with -inline -boundscheck=off -singleobj flags

Nice.