std.experimental.testing PR review

Atila Neves via Digitalmars-d digitalmars-d at puremagic.com
Mon Apr 20 07:29:32 PDT 2015


On Monday, 20 April 2015 at 13:50:59 UTC, Jacob Carlborg wrote:
> On 2015-04-20 15:28, Atila Neves wrote:
>> Original library: http://code.dlang.org/packages/unit-threaded
>> PR: https://github.com/D-Programming-Language/phobos/pull/3207
>>
>> It's my first Phobos PR, I tried reading the wiki and doing 
>> what's
>> required but bear with me if I've screwed up somehow.
>
> Any new module must go through the review queue [1]. Ask here 
> in the newsgroup for a review on the code. Generated 
> documetnation and code should be available for the module. A 
> review manager will volunteer to manage the review. When a 
> module has been approved, first then should a pull request be 
> created.
>
> [1] http://wiki.dlang.org/Review_Queue

I saw links to PRs past with generated docs but have/had no
idea how to get a similar result. Besides the html make target,
what is it a person has to do exactly? I'm going to edit the wiki
with this information as well.

Atila


More information about the Digitalmars-d mailing list