formal review

Andrei Alexandrescu via Digitalmars-d digitalmars-d at
Fri Aug 21 09:54:37 PDT 2015

On 8/19/15 4:55 AM, Sönke Ludwig wrote:
> Am 19.08.2015 um 03:58 schrieb Andrei Alexandrescu:
>> On 8/18/15 1:24 PM, Jacob Carlborg wrote:
>>> On 2015-08-18 17:18, Andrei Alexandrescu wrote:
>>>> Me neither if internal. I do see a problem if it's public. -- Andrei
>>> If it's public and those 20 lines are useful on its own, I don't see a
>>> problem with that either.
>> In this case at least they aren't. There is no need to import the JSON
>> exception and the JSON location without importing anything else JSON. --
>> Andrei
> The only other module where it would fit would be lexer.d, but that
> means that importing JSONValue also has to import the parser and lexer
> modules, which is usually only needed in a few places.

I'm sure there are a number of better options to package things nicely. 
-- Andrei

More information about the Digitalmars-d mailing list