10 Tips for Better Pull Requests

ketmar via Digitalmars-d digitalmars-d at puremagic.com
Fri Jan 16 08:22:02 PST 2015


On Fri, 16 Jan 2015 08:10:50 -0800
Andrei Alexandrescu via Digitalmars-d <digitalmars-d at puremagic.com>
wrote:

> On 1/16/15 7:50 AM, H. S. Teoh via Digitalmars-d wrote:
> > On Thu, Jan 15, 2015 at 08:20:32PM -0800, Walter Bright via Digitalmars-d wrote:
> >> http://blog.ploeh.dk/2015/01/15/10-tips-for-better-pull-requests/
> >>
> >> I agree with pretty much everything in this article.
> >>
> >> tl,dr:
> >>
> >> "The more you make your reviewer work, the greater the risk is that
> >> your Pull Request will be rejected."
> >
> > In the case of D, "the more you make your reviewer(s) work, the greater
> > the risk is that your Pull Request will sit in the queue forever." :-P
> 
> I think it would be great if we defined a simple policy for closing pull 
> requests that are lingering. -- Andrei
it sits in queue without any comments more than 20 days? reject and
close it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.puremagic.com/pipermail/digitalmars-d/attachments/20150116/ea9eb42d/attachment.sig>


More information about the Digitalmars-d mailing list