10 Tips for Better Pull Requests

Tobias Pankrath via Digitalmars-d digitalmars-d at puremagic.com
Fri Jan 16 09:16:38 PST 2015


On Friday, 16 January 2015 at 16:22:13 UTC, ketmar via 
Digitalmars-d wrote:
> On Fri, 16 Jan 2015 08:10:50 -0800
> Andrei Alexandrescu via Digitalmars-d 
> <digitalmars-d at puremagic.com>
> wrote:
>
>> On 1/16/15 7:50 AM, H. S. Teoh via Digitalmars-d wrote:
>> > On Thu, Jan 15, 2015 at 08:20:32PM -0800, Walter Bright via 
>> > Digitalmars-d wrote:
>> >> http://blog.ploeh.dk/2015/01/15/10-tips-for-better-pull-requests/
>> >>
>> >> I agree with pretty much everything in this article.
>> >>
>> >> tl,dr:
>> >>
>> >> "The more you make your reviewer work, the greater the risk 
>> >> is that
>> >> your Pull Request will be rejected."
>> >
>> > In the case of D, "the more you make your reviewer(s) work, 
>> > the greater
>> > the risk is that your Pull Request will sit in the queue 
>> > forever." :-P
>> 
>> I think it would be great if we defined a simple policy for 
>> closing pull requests that are lingering. -- Andrei
> it sits in queue without any comments more than 20 days? reject 
> and
> close it.

Bad idea. Take for example this one of mine 
https://github.com/D-Programming-Language/phobos/pull/2793 that 
sits there for more than 20 days. I've addressed all concerns and 
now it's waiting for someone who feels responsible for 
std.container to pull it.

Now four things can happen:

1. Someone pulls it. Fine.
2. Someone says, that after consideration this is not suitable 
for std.container. Fine.
3. Someone raises more QOI concerns. Fine.
4. Someone says, that the pull is rejected, because it was 
sitting there for more than 20 days. It would be my very last 
pull request. Period.






More information about the Digitalmars-d mailing list