10 Tips for Better Pull Requests

Tobias Pankrath via Digitalmars-d digitalmars-d at puremagic.com
Fri Jan 16 09:41:11 PST 2015


>> Bad idea. Take for example this one of mine
>> https://github.com/D-Programming-Language/phobos/pull/2793 
>> that sits
>> there for more than 20 days. I've addressed all concerns and 
>> now it's
>> waiting for someone who feels responsible for std.container to 
>> pull it.
>>
>> Now four things can happen:
>>
>> 1. Someone pulls it. Fine.
>> 2. Someone says, that after consideration this is not suitable 
>> for
>> std.container. Fine.
>> 3. Someone raises more QOI concerns. Fine.
>> 4. Someone says, that the pull is rejected, because it was 
>> sitting there
>> for more than 20 days. It would be my very last pull request. 
>> Period.
>
> Thanks for raising attention to this. I didn't know about your 
> pull request. A while ago I found my Inbox flooded by 
> github-related messages so I directed them into a different 
> folder. That has right now 13113 unread messages.
>
> Your work is interesting and necessary. I shall destroy it soon 
> :o).
>
>
> Andrei

That reply was not about my pull request specifically. Since it 
basically consists of two new files, it can stay there for months 
without generating any additional work for me. But it is a good 
counterexample to the »just close old stuff«-policy.


More information about the Digitalmars-d mailing list