10 Tips for Better Pull Requests

aldanor via Digitalmars-d digitalmars-d at puremagic.com
Fri Jan 16 11:54:17 PST 2015


On Friday, 16 January 2015 at 18:50:29 UTC, deadalnix wrote:
> On Friday, 16 January 2015 at 16:22:13 UTC, ketmar via 
> Digitalmars-d wrote:
>> it sits in queue without any comments more than 20 days? 
>> reject and
>> close it.
>
> It is better to have some kind of bot that comment on the PR 
> after a while. Like "hey, this PR is hanging, can someone make 
> thing go forward or I'll close in 2 more month". That generate 
> activity on the PR and is often a wake up call for people.

On a relevant sidenote: this is a GitHub buildbot that manages 
Rust's main repo, PR approvals and all that: 
https://github.com/graydon/bors

IMO that seems to work quite well for Rust and lowers the 
administrative burden on reviewers.


More information about the Digitalmars-d mailing list