10 Tips for Better Pull Requests

Andrei Alexandrescu via Digitalmars-d digitalmars-d at puremagic.com
Fri Jan 16 12:44:29 PST 2015


On 1/16/15 11:23 AM, Walter Bright wrote:
> On 1/16/2015 9:49 AM, Andrei Alexandrescu wrote:
>> I'm thinking of something like: if there's $(legitimate) request for
>> changes but
>> the author is dormant for more than $(X) days, then close.
>
> That's also a hamfisted policy. I've seen PR's that were good, but
> needed a bit of work, but the author disappeared. Sometimes, I've taken
> those over and finished them.
>
> Arbitrarily closing them means they get lost forever.

Look for a champion after $(X) days? It looks like once a pull request 
is open it's impossible to close it. There's got to be some garbage 
collection somehow :o). -- Andrei


More information about the Digitalmars-d mailing list