10 Tips for Better Pull Requests

Vladimir Panteleev via Digitalmars-d digitalmars-d at puremagic.com
Fri Jan 16 12:48:16 PST 2015


On Friday, 16 January 2015 at 19:23:06 UTC, Walter Bright wrote:
> On 1/16/2015 9:49 AM, Andrei Alexandrescu wrote:
>> I'm thinking of something like: if there's $(legitimate) 
>> request for changes but
>> the author is dormant for more than $(X) days, then close.
>
> That's also a hamfisted policy. I've seen PR's that were good, 
> but needed a bit of work, but the author disappeared. 
> Sometimes, I've taken those over and finished them.
>
> Arbitrarily closing them means they get lost forever.

Add an "abandoned" label, and assign it when closing? Then they 
won't get lost, but also won't clutter the list.


More information about the Digitalmars-d mailing list