std.experimental.logger formal review round 3

[Andrei Alexandrescu via Digitalmars-d]

On 1/24/15 7:06 AM, Dicebot wrote:
> On Friday, 23 January 2015 at 20:24:54 UTC, Andrei Alexandrescu wrote:
>> I propose we pull this in today and make it available for 2.067 as
>> std.experimental.logger.
>>
>> We've been through a number of iterations with this and the best way
>> to move forward is to accumulate a bit of real-world experience with
>> it. Since we're deploying to std.experimental there is understanding
>> breaking changes are still possible.
>>
>> Dicebot, as the review manager you get to decide. What do you say?
>>
>>
>> Andrei
>
> I was in favor of merging it long time ago. It is _your_ defintion of
> being good enough for std.experimental I am trying to comply now ;)
> Merging it right now and continuing with fixes as follow-up pull
> requests is a good idea but you must understand that chance of breaking
> chance is very high.
>
> That said I have just now tested last version (with thread-local log
> support) and apart from one bug found it works as expected. Assuming you
> give your LGTM I will merge the PR as soon as this bug is fixed and PR
> is rebased/squashed.

Fantastic. Thanks! Robert, please mind the bug and then Dicebot please 
do the merge honors.

Thanks Robert for this work, Dicebot for overseeing the review process, 
and everybody in the community who provided feedback and ideas.


Andrei