Phobos addition formal review: std.experimental.allocator

Tofu Ninja via Digitalmars-d digitalmars-d at puremagic.com
Sat Jun 13 15:59:05 PDT 2015


On Saturday, 13 June 2015 at 15:48:31 UTC, Andrei Alexandrescu 
wrote:
> On 6/13/15 3:14 AM, Dicebot wrote:
>> Andrei, have you considered creating additional 
>> std.allocator.impl
>> package and moving actual allocators there? Or, probably, the 
>> other way
>> around with std.allocator.core
>>
>> Existing flat hierarchy does not hint about internal structure 
>> in any way.
>
> It's good documentation, not directories, that helps 
> understanding internal structure. There are 23 files in 
> std/experimental/allocator, which seems manageable. I think 
> we're good as we are.
>
> Andrei

Personally, I disagree, the flat hierarchy was the first thing I 
noticed and I thought the same thing as Dicebot.

And its 23 now, but what about when new allocators get added. I 
don't think there is really a cost to moving it to a new folder, 
just makes things clearer. Any ways isn't the flat hierarchy 
something people have been complaining about Phobos in general?


More information about the Digitalmars-d mailing list