Making byLine faster: we should be able to delegate this

Andrei Alexandrescu via Digitalmars-d digitalmars-d at puremagic.com
Mon Mar 23 20:32:58 PDT 2015


On 3/23/15 6:44 PM, Steven Schveighoffer wrote:
> On 3/23/15 9:17 PM, Steven Schveighoffer wrote:
>> I re-examined and found something interesting -- assumeSafeAppend
>> doesn't cache the block, it only uses the cache if it's ALREADY cached.
>>
>> So a large chunk of that 35% is the runtime looking up that block info
>> in the heap. On my machine, this brings the time from .3 down to .2 s.
>>
>> I also found a bad memory corruption bug you introduced. I'll make some
>> PRs.
>
> https://github.com/D-Programming-Language/druntime/pull/1198
> https://github.com/D-Programming-Language/phobos/pull/3098
>
> Note, this doesn't affect performance in this case, as assumeSafeAppend
> isn't used any more.

Can't tell how much I appreciate this work! -- Andrei



More information about the Digitalmars-d mailing list