"Good PR" mechanical check

Sebastiaan Koppe via Digitalmars-d digitalmars-d at puremagic.com
Tue Jan 12 13:56:19 PST 2016


On Tuesday, 12 January 2016 at 21:04:33 UTC, Jacob Carlborg wrote:
> On 2016-01-12 15:53, Adam D. Ruppe wrote:
>
>> I'm not sure if git supports this but I think it should be 
>> done fully
>> automatically. Not even something the user runs, just when 
>> they open the
>> pull request, it reformats the code.
>
> The hook/tool would need to do a commit with the changes. How 
> would what work? The tool wouldn't have commit access to the 
> repository from where the PR originates. It would also create a 
> new commit hash that wouldn't match with what the user have 
> locally.

Yeah, don't know how that can be made to work.

The closest I got was 
https://help.github.com/articles/about-webhooks/ at least then 
you can check whether dfmt agrees with the pull request (and 
block it)

But people still need to manually run the thing.


More information about the Digitalmars-d mailing list