DMD PR management hits a new low

user1234 user1234 at 12.nl
Sun Nov 19 02:22:22 UTC 2017


On Sunday, 19 November 2017 at 01:40:32 UTC, codephantom wrote:
> On Saturday, 18 November 2017 at 23:21:08 UTC, user1234 wrote:
>> It seems that they close systematically after a month or so.
>> You need to hire a vilain that will do this dirty job for you 
>> (or maybe even use a bot)...everybody will hate him but the 
>> stack of folder on the desktop will get smaller.
>
> Sounds like a job for SysAdmin.
>
> A smart sysadmin would implement the bot option (cause then you 
> can blame the bot).
>
> Just need to establish clear and fair criteria for the bot, and 
> then implement it.

I'd propose these rules for the dbot:

- no human review comment (codecov + dbot automatically comment): 
never close
- never close if tag is set (e.g DIP implementation, experimental 
phobos addition, etc.)
- three months after last update: warn.
- six months after last update: close, politely, w/ explanations

Personally i don't understand how people can stand to have their 
old PRs opened.
Usually i close myself after 1 month, which is rare, usually 
things are handled in the two weeks that follow the opening. I 
say that but i've never submitted anything big...





More information about the Digitalmars-d mailing list