DIP 1017--Add Bottom Type--Final Review

Nicholas Wilson iamthewilsonator at hotmail.com
Tue Jan 15 12:41:28 UTC 2019


On Tuesday, 15 January 2019 at 08:59:07 UTC, Mike Parker wrote:
> DIP 1017, "Add Bottom Type", is now ready for Final Review. 
> This is the last chance for community feedback before the DIP 
> is handed off to Walter and Andrei for the Formal Assessment. 
> Please read the procedures document for details on what is 
> expected in this review stage:
>
> https://github.com/dlang/DIPs/blob/master/PROCEDURE.md#final-review
>
> The current revision of the DIP for this review is located here:
>
> https://github.com/dlang/DIPs/blob/4716033a8cbc2ee024bfad8942b2ff6b63521f63/DIPs/DIP1017.md
>
> In it you'll find a link to and summary of the previous review 
> round. This round of review will continue until 11:59 pm ET on 
> January 30 unless I call it off before then.
>
> Thanks in advance for your participation.

No, absolutely no.

This shouldn't have passed draft review, this shouldn't have 
passed community review and it _absolutely_ should not pass 
final. This is a complete waste of review time, nothing has 
changed based on past reviews:

No rationale has been given for this over the status quo for 
achieving this in LDC and GDC using an @attribute.

It is confusing in its specification of interaction and looks to 
be complicated in its implementation for _zero_ gain in 
functionality, neither documentation, nor optimisation.

I'm not sure what the process is for dealing with "major flaws 
are discovered" that were discovered, bought up and ignored 
completely with _zero_ communications, not even a refutation, in 
_every_ _previous_ _review_.

I cannot be more blunt:
This final review should discarded, and the DIP sent back to 
draft review, postponed until the author has addressed the points 
raised in the draft review, or simply rejected.



More information about the Digitalmars-d mailing list