Generality creep
ag0aep6g
anonymous at example.com
Thu Mar 28 23:05:24 UTC 2019
On 28.03.19 22:33, Walter Bright wrote:
> This one caught my eye because I had just
> finished making those ranges DIP1000 compatible, and then some large
> changes to them followed right afterwards, and I thought they might be
> related.
I don't mind you being against those changes, but the changes so far are
hardly "large". Ignoring the tests, both my PRs combined add meager 20
lines. And that's for seven bug fixes.
By the way, you recently made changes to `save` methods in std.utf:
https://github.com/dlang/phobos/pull/6900
https://github.com/dlang/phobos/pull/6903
I'm not sure why you made those, but they touch the same kind of code as
my PRs, and they actually fix the issue I was fixing, too. Are you
planning on applying that pattern to all of Phobos, or just std.utf for
some reason?
If you're going for all of Phobos, you might end up fixing issue 18657
as a side effect. But removing RefRange.opAssign would still be nice,
because it's just weird.
More information about the Digitalmars-d
mailing list